[PATCH] D58536: [Sanitizer] Rework BufferedStackTrace::Unwind (part 1)

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/ubsan/ubsan_diag_standalone.cc:25
   bool request_fast_unwind = common_flags()->fast_unwind_on_fatal;
-  if (__sanitizer::StackTrace::WillUseFastUnwind(request_fast_unwind))
-    __sanitizer::GetThreadStackTopAndBottom(false, &top, &bottom);
----------------
Would be nice to have separate NFC patch for stuff like removing _sanitizer::


================
Comment at: compiler-rt/lib/ubsan/ubsan_diag_standalone.cc:31
   BufferedStackTrace stack;
-  stack.Unwind(kStackTraceMax, pc, bp, nullptr, top, bottom,
-               request_fast_unwind);
----------------
Could you also make another NFC patch for:
Unwind(... bool) -> FastUnwind/SlowUnwind


================
Comment at: compiler-rt/lib/ubsan/ubsan_diag_standalone.cc:34
+  else
+    stack.SlowUnwindStack(pc, kStackTraceMax);
   stack.Print();
----------------
SlowUnwindStack -> just SlowUnwind
Word Stack is redundant there at it's a member of the StackTrace


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58536/new/

https://reviews.llvm.org/D58536