[PATCH] D58234: [llvm-objcopy] Add --add-symbol

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-objcopy/CopyConfig.h:68
+  StringRef SectionName;
+  unsigned long long Value = 0;
+  uint8_t Type = ELF::STT_NOTYPE;
----------------
uint64_t


================
Comment at: tools/llvm-objcopy/ObjcopyOpts.td:242
+defm add_symbol
+     : Eq<"add-symbol", "Add new symbol <name> to .symtab.">,
+       MetaVarName<"name=[section:]value[,flags]">;
----------------
We should list all all the flags we support here, something like:

"Add new symbol <name> to .symtab. Accepted flags: global, local, weak, default, hidden, file, section, object, function, indirect-function. Accepted but ignored for compatibility: debug, constructor, warning, indirect, synthetic, unique-object, before."

I think string you have is actually fine for --help, but we don't have a man page to put the more verbose info in, so we should include it in --help so we have it //somewhere//. We should probably create a man page for llvm-objcopy in the llvm-9 release and make these docs simpler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58234/new/

https://reviews.llvm.org/D58234