[PATCH] D20582: Don't add repeats of llvm.ident list when linking

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D20582#1407184 <https://reviews.llvm.org/D20582#1407184>, @dexonsmith wrote:

> It’s unfortunate that this will be quadratic in the number of modules.  Is there a way we could improve that?


Well the linker API only exposes linking one module into one other at at time, so I don't know. Currently we have the AMDGPUUnifyMetadata pass as a workaround which cleans these up in a pass over the fully linked module, so that avoids revisiting for each module but it would make more sense if the linker dealt with this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D20582/new/

https://reviews.llvm.org/D20582