[PATCH] D58430: [PowerPC] Enhance the fast selection of fptoi & fptrunc instruction and clean up related asserts
Jinsong Ji via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 22 07:59:11 PST 2019
jsji accepted this revision.
jsji added a comment.
This revision is now accepted and ready to land.
LGTM, except minor comments update.
================
Comment at: llvm/lib/Target/PowerPC/PPCFastISel.cpp:1210
// Convert f32 to f64 if necessary. This is just a meaningless copy
// to get the register class right.
----------------
We should update the comments here too.
================
Comment at: llvm/lib/Target/PowerPC/PPCFastISel.cpp:1217
// Determine the opcode for the conversion, which takes place
// entirely within FPRs.
unsigned DestReg;
----------------
We should update the comments here too.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58430/new/
https://reviews.llvm.org/D58430
More information about the llvm-commits
mailing list