[PATCH] D58096: [LowerSwitch][AMDGPU] Do not handle impossible values

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 06:46:29 PST 2019


arsenm added inline comments.


================
Comment at: lib/Transforms/Utils/LowerSwitch.cpp:494
+    // Constraining the range of the value being switched over helps eliminating
+    // unreachable BBs and minimizing the number of add's newLeafBlock ends up
+    // emitting. Running CorrelatedValuePropagation after LowerSwitch isn't as
----------------
rtereshin wrote:
> arsenm wrote:
> > Typo add's
> Not sure what do you mean. By add's I meant `add` instructions. I will replace it with that to avoid confusion, thanks!
It's a plural, not a possessive so it should be adds


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58096/new/

https://reviews.llvm.org/D58096





More information about the llvm-commits mailing list