[PATCH] D51589: DAG: Fold extract_vector_elt (scalar_to_vector), K to undef

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

The patch has rotted and needs rewriting, but putting in an assert causes hits in these tests:

  Failing Tests (16):
      LLVM :: CodeGen/AMDGPU/copy-illegal-type.ll
      LLVM :: CodeGen/AMDGPU/cvt_f32_ubyte.ll
      LLVM :: CodeGen/AMDGPU/flat_atomics_i64.ll
      LLVM :: CodeGen/AMDGPU/global_atomics_i64.ll
      LLVM :: CodeGen/AMDGPU/load-constant-i1.ll
      LLVM :: CodeGen/AMDGPU/load-constant-i16.ll
      LLVM :: CodeGen/AMDGPU/load-global-i1.ll
      LLVM :: CodeGen/AMDGPU/load-global-i16.ll
      LLVM :: CodeGen/AMDGPU/load-local-i1.ll
      LLVM :: CodeGen/AMDGPU/load-local-i16.ll
      LLVM :: CodeGen/AMDGPU/max.i16.ll
      LLVM :: CodeGen/AMDGPU/min.ll
      LLVM :: CodeGen/AMDGPU/select.f16.ll
      LLVM :: CodeGen/AMDGPU/selectcc.ll
      LLVM :: CodeGen/AMDGPU/v_madak_f16.ll
      LLVM :: CodeGen/X86/vector-intrinsics.ll

If possible please can you use one of these to show a codegen change? I tried the x86 test but didn't find anything.

TBH, I think this patch can be accepted anyhow as we know the codepath is being tested, its just annoying that it doesn't show up in test codegen....


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51589/new/

https://reviews.llvm.org/D51589