[PATCH] D58468: [DAGCombine] Fold overlapping constant stores

[Clement Courbet via Phabricator via llvm-commits]

courbet added a comment.

LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15441
+
+        // If ST stores to a subset of preceeding stores value, we may be able
+        // to fold ST's value into the predeeding stored value. As we know the
----------------
nit: `preceding` (here and elsewhere)


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:15454
+              if (DAG.getDataLayout().isBigEndian())
+                Offset = ChainByteSize-1-Offset;
+              Val.insertBits(InsertVal, Offset * 8);
----------------
clang-format ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58468/new/

https://reviews.llvm.org/D58468