[PATCH] D58510: [yaml2obj]Allow explicit symbol indexes in relocations and emit error for bad names

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 22 00:28:47 PST 2019


grimar added inline comments.


================
Comment at: tools/yaml2obj/yaml2elf.cpp:538
+        return false;
+      }
 
----------------
I suggest merging `if`s

```
  if (Rel.Symbol && SymN2I.lookup(*Rel.Symbol, SymIdx) &&
      !to_integer(*Rel.Symbol, SymIdx)) {

```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58510/new/

https://reviews.llvm.org/D58510





More information about the llvm-commits mailing list