[PATCH] D58498: [obj2yaml] - Do not miss section index for special symbols.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 23:56:20 PST 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/tools/obj2yaml/special-symbols-indices.yaml:1
+# RUN: yaml2obj %s > %t
+# RUN: obj2yaml %t | FileCheck %s
----------------
jhenderson wrote:
> Nit: test name should be special-symbol-indices.test (you do not need to make "symbol" plural).
Thanks :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58498/new/

https://reviews.llvm.org/D58498





More information about the llvm-commits mailing list