[PATCH] D58313: [hwasan,asan] Intercept vfork.

Thu Feb 21 16:13:32 PST 2019

eugenis marked an inline comment as done.
eugenis added inline comments.

================
Comment at: compiler-rt/test/asan/TestCases/Linux/vfork.cc:4
+
+// REQUIRES: aarch64-android-target-arch
+
----------------
pcc wrote:
> eugenis wrote:
> > pcc wrote:
> > > Doesn't this need to be spelled `REQUIRES: aarch64-target-arch, android`? (Also, does it really require Android?)
> > I've dumped available features, and that's the only relevant one I found.
> > Perhaps this could be fixed, but in a separate commit.
> That's fine. I noticed that `compiler-rt/test/shadowcallstack/overflow-aarch64.c` was already using `aarch64-target-arch`, maybe that's never being run? If so that would probably need to be fixed as well.
I've looked, and this aarch64-android-target-arch is only present in asan and scudo, and it affects exactly 0 tests one way or the other.

I'll remove it in a separate change.

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58313/new/

https://reviews.llvm.org/D58313