[PATCH] D58513: [libFuzzer][Windows] Port fork mode to Windows

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In D58513#1406402 <https://reviews.llvm.org/D58513#1406402>, @zturner wrote:

> In D58513#1406398 <https://reviews.llvm.org/D58513#1406398>, @metzman wrote:
>
> > In D58513#1406388 <https://reviews.llvm.org/D58513#1406388>, @zturner wrote:
> >
> > > Can you try `mountvol <PATH>\mount C:\` and see what you print in this case?
> >
> >
> > This seems to break:
> >
> >   File: <PATH>\test-dir\dir\file-symlink2
> >   File: <PATH>\test-dir\dir\y.txt
> >   Dir: <PATH>\test-dir\dir
> >   File: <PATH>\test-dir\dir-junction\file-symlink2
> >   File: <PATH>\test-dir\dir-junction\y.txt
> >   Dir: <PATH>\test-dir\dir-junction
> >   File: <PATH>\test-dir\dir-Shortcut.lnk
> >   File: <PATH>\test-dir\dir-symlink\file-symlink2
> >   File: <PATH>\test-dir\dir-symlink\y.txt
> >   Dir: <PATH>\test-dir\dir-symlink
> >   File: <PATH>\test-dir\edge-case
> >   File: <PATH>\test-dir\file-hardlink1
> >   File: <PATH>\test-dir\file-hardlink2
> >   File: <PATH>\test-dir\file-symlink
> >   File: <PATH>\test-dir\file.txt
> >   FindFirstFileA failed with error 5 for directory: <PATH>\ss64\$Recycle.Bin\blah; exiting
> >
> >
> > I'm not sure what the correct behavior in this case is though.
>
>
> Actually just use a different directory then.  Like mount D: instead of C:.  Recycle bin is protected, so you probably won't be able to get directly into it without special permissions.
>
> What I'm really wondering about is whether a volume mounted with mountvol will fall into your directory branch or your file branch.  It should go into your directory branch.
>
> That said, it looks like this does find a more general bug, which is that if the directory is inaccessible you will fail and terminate the iteration.  You should probably handle this gracefully and just return from the function is `FindFirstFile` fails.


FWIW I think you could reproduce this same bug without mountvol by just making a directory and creating a Deny All ACL on it, and that should definitely be handled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58513/new/

https://reviews.llvm.org/D58513