[PATCH] D57823: [ARM] Make fullfp16 instructions not conditionalisable.

Thu Feb 21 13:15:13 PST 2019

efriedma added a comment.

Do we need special handling for fp16 NEON instructions in Thumb mode?  I think the compiler won't predicate them anyway (it's deprecated, and some CPUs have known errata; see ARMBaseInstrInfo::isPredicable), but it might affect the assembler.

Does the disassembler also need any special handling here?  I guess that's less of a priority, but maybe something to look into as a followup.

================
Comment at: llvm/test/CodeGen/ARM/fp16-no-condition.ll:27
+; CHECK-LABEL: chained_comparisons:
+; CHECK-NOT: vcmpne.f16
+entry:
----------------
Should explicitly check for vcmp.f16.  And we should probably have a corresponding test for vcmpne.f32 to make sure this is actually testing what it's supposed to test.  (I think the compiler already refuses to predicate NEON instructions because it's deprecated, but I guess that doesn't apply here.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57823/new/

https://reviews.llvm.org/D57823