[PATCH] D58522: AMDGPU/NFC: Cleanup subtarget predicates

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPU.td:685
+  Predicate<"Subtarget->getGeneration() >= AMDGPUSubtarget::SEA_ISLANDS">,
+  AssemblerPredicate<"FeatureCIInsts">;
+
----------------
The assembler predicate is sort of inaccurate, but is it really needed?


================
Comment at: lib/Target/AMDGPU/AMDGPU.td:689
+  Predicate<"Subtarget->getGeneration() >= AMDGPUSubtarget::VOLCANIC_ISLANDS">,
+  AssemblerPredicate<"FeatureVIInsts">;
 
----------------
Ditto


================
Comment at: lib/Target/AMDGPU/AMDGPU.td:693
+  Predicate<"Subtarget->getGeneration() >= AMDGPUSubtarget::GFX9">,
   AssemblerPredicate<"FeatureGFX9Insts">;
 
----------------
Ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58522/new/

https://reviews.llvm.org/D58522