[PATCH] D58433: AddressSanitizer: fix for SPARC with GCC
Eric Botcazou via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 21 09:28:45 PST 2019
ebotcazou marked an inline comment as done.
ebotcazou added inline comments.
================
Comment at: compiler-rt/lib/asan/asan_globals.cc:119
+#if defined(__GNUC__) && defined(__sparc__)
+ internal_memcpy(&globals[res], &g, sizeof(g));
+#else
----------------
ro wrote:
> It would be helpful the have the explanation from the summary
> as a comment in the code so it becomes immediately obvious
> what's going on.
Other similar uses of internal_memcpy don't have a comment, but I can add one.
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58433/new/
https://reviews.llvm.org/D58433
More information about the llvm-commits
mailing list