[compiler-rt] r354601 - Revert "[sanitizers] Restore internal_readlink for x32"

Matt Morehouse via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 21 09:06:23 PST 2019


Author: morehouse
Date: Thu Feb 21 09:06:23 2019
New Revision: 354601

URL: http://llvm.org/viewvc/llvm-project?rev=354601&view=rev
Log:
Revert "[sanitizers] Restore internal_readlink for x32"

This reverts r354451 since it broke the Windows sanitizer bot.

Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc
    compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc?rev=354601&r1=354600&r2=354601&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc Thu Feb 21 09:06:23 2019
@@ -400,7 +400,7 @@ uptr internal_readlink(const char *path,
   return internal_syscall(SYSCALL(readlinkat), AT_FDCWD, (uptr)path, (uptr)buf,
                           bufsize);
 #else
-  return internal_syscall(SYSCALL(readlink), (uptr)path, (uptr)buf, bufsize);
+  return internal_syscall(SYSCALL(readlink), path, buf, bufsize);
 #endif
 }
 

Modified: compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc?rev=354601&r1=354600&r2=354601&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/tests/sanitizer_common_test.cc Thu Feb 21 09:06:23 2019
@@ -438,9 +438,4 @@ TEST(SanitizerCommon, ReservedAddressRan
   EXPECT_DEATH(address_range.Unmap(base_addr + (PageSize * 2), PageSize), ".*");
 }
 
-TEST(SanitizerCommon, ReadBinaryNameCached) {
-  char buf[256];
-  EXPECT_NE((uptr)0, ReadBinaryNameCached(buf, sizeof(buf)));
-}
-
 }  // namespace __sanitizer




More information about the llvm-commits mailing list