[PATCH] D58498: [obj2yaml] - Do not miss section index for SHN_ABS and SHN_COMMON symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/obj2yaml/abs-common-symbols.yaml:1
+# RUN: yaml2obj %s > %t
+# RUN: obj2yaml %t | FileCheck %s
----------------
The test needs renaming to show its more general purpose now. Also maybe worth a comment to describe the test ;-)


================
Comment at: test/tools/obj2yaml/abs-common-symbols.yaml:10
+# CHECK-NEXT:     - Name:    absolute2
+# CHECK-NEXT:       Index:   SHN_ABS
+# CHECK-NEXT:       Value:   0x0000000000004321
----------------
The point of the original test was to show that both SHN_ABS and 0xfff1 can be handled. I don't think it matters too much whether both are tested or not, but there's not much point in having duplicates.


================
Comment at: test/tools/obj2yaml/abs-common-symbols.yaml:21
+# CHECK-NEXT:     - Name:    processor_specific_index2
+# CHECK-NEXT:       Index:   SHN_HEXAGON_SCOMMON_1
+
----------------
How about testing another arbitrary value in the reserved range that doesn't necessarily correspond to any known value?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58498/new/

https://reviews.llvm.org/D58498