[PATCH] D57321: Fix LexFloatLiteral Lexing

[Brandon Jones via Phabricator via llvm-commits]

BrandonTJones marked an inline comment as done.
BrandonTJones added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:73
+  if (*CurPtr == '-' || *CurPtr == '+')
+    return ReturnError(CurPtr, "Invalid sign in float literal");
+  // Check for exponent; we enforce rigidity on a correct
----------------
efriedma wrote:
> Is this early return necessary, or just to try to improve the error messages?
Improve the error message, it feels ambiguous to allow the error message to be from the parser not expecting 2 floats in a row.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57321/new/

https://reviews.llvm.org/D57321