[PATCH] D58496: [llvm-readobj] Change "SHT_MIPS_DWARF" to "MIPS_DWARF"
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 21 03:16:18 PST 2019
MaskRay marked an inline comment as done.
MaskRay added inline comments.
================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2863-2864
return "MIPS_OPTIONS";
+ case SHT_MIPS_DWARF:
+ return "MIPS_DWARF";
case SHT_MIPS_ABIFLAGS:
----------------
jhenderson wrote:
> Is there a good reason to reorder this? For diff-ability, it would be better if the ordering is maintained.
Because SHT_MIPS_DWARF < SHT_MIPS_ABIFLAGS and it is the order used in several other places. I can update the description to mention this.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58496/new/
https://reviews.llvm.org/D58496
More information about the llvm-commits
mailing list