[PATCH] D58457: [llvm-readobj]Add testing for ELF symbol and section table printing for a wider range of values

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Test cases look fine to me, but I would add descriptions about what test is about (where missing), like you did for elf-section-types.test



================
Comment at: test/tools/llvm-readobj/elf-symbol-shndx.test:1
+# Use --dyn-symbols because yaml2obj does not currently support large section indexes
+# and also does not allow hand-crafting of static symbol tables.
----------------
I would add a test description at first. Because when you start the test from explaining the implementation
with "use --dyn-symbols because..." this raises a question in my head: "but what this test is about?"


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58457/new/

https://reviews.llvm.org/D58457