[PATCH] D57806: [Interpreter] Add newline to interpreter debugging output
Kristof Beyls via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 21 00:02:52 PST 2019
kristof.beyls added a comment.
This seems quite obvious.
Typically when we change the behaviour of code, we aim to add a unit/regression test to check that indeed the code now has the intended behaviour (and mostly to make sure future changes do not regress on that expected behaviour).
That being said, this is a change to debug output, for which we typically do not add regression tests.
They only thing that is holding me back to approve this change is that I am completely unfamiliar with the interpreter.
If on this review you could share a small example of behaviour before and after this change as a sanity check, I'd be happy to approve.
Thanks,
Kristof
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57806/new/
https://reviews.llvm.org/D57806
More information about the llvm-commits
mailing list