[PATCH] D58487: [WebAssembly] Don't create MSSymbolWasm object for non-symbols

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 23:06:33 PST 2019


tlively added a comment.

In D58487#1405275 <https://reviews.llvm.org/D58487#1405275>, @sbc100 wrote:

> In D58487#1405260 <https://reviews.llvm.org/D58487#1405260>, @tlively wrote:
>
> > LGTM. Makes me wonder why it was ever done the other way.
>
>
> Sorry I know this messes with you open PR..  should I hold of committing this until we reach consensus on your change?


No need to wait. My PR can easily be updated to be rebased on top of this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58487/new/

https://reviews.llvm.org/D58487





More information about the llvm-commits mailing list