[PATCH] D57601: Seperate volatility and atomicity/ordering in SelectionDAG

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D57601#1404320 <https://reviews.llvm.org/D57601#1404320>, @jyknight wrote:

> In D57601#1397317 <https://reviews.llvm.org/D57601#1397317>, @reames wrote:
>
> > Question for Reviewers: Going through uses of isVolatile in backend code, I see suspicious bits in Lania, ARM, and Hexagon.  What's the best way to handle this?  I can easily apply the workaround I mention for out of tree backends, or I could make them equally conservative for isAtomic.  The other in tree backends appear to be fine, though I'd welcome review from folks knowledgeable of non-x86 backends.
>
>
> I think adding the isAtomic check to the appropriate locations that are checking isVolatile makes the most sense, since it's easier to see and undo in the future, if that's desired.


D58490 <https://reviews.llvm.org/D58490> is posted for review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57601/new/

https://reviews.llvm.org/D57601