[PATCH] D58336: [X86] Fix tls variable lowering issue with large code model

Wed Feb 20 17:59:05 PST 2019

LuoYuanke marked an inline comment as done.
LuoYuanke added inline comments.

================
Comment at: test/CodeGen/X86/code-model-elf.ll:378

+define dso_local i32 @load_thread_data() #0 {
+; SMALL-STATIC-LABEL: load_thread_data:
----------------
rnk wrote:
> These all look the same. Is that correct for the large code model? I thought in the large code model the GOT would be in a PIC register, which I don't see below. Is that known? Maybe there should be a FIXME comment here if you don't consider that to be in scope of this change.
The result is same because we specify -fpie option in the test code. I notice tls large model for pic support is still not accurate, but it should be fixed in another patch. The patch focus on static tls or initial exec tls. The idea to add a FIXME comment is good. I'll do it.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58336/new/

https://reviews.llvm.org/D58336