[PATCH] D58472: [WebAssembly] Remove unneeded MCSymbolRefExpr variants

[Heejin Ahn via Phabricator via llvm-commits]

aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

Looks OK to me, we have all the info in `MCSymbolWasm` after all.



================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1559
+      auto *SymRef = dyn_cast<MCSymbolRefExpr>(Expr);
+      const auto &TargetSym = cast<const MCSymbolWasm>(SymRef->getSymbol());
+      if (!SymRef)
----------------
I guess this should be below `if (!SymRef)` test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58472/new/

https://reviews.llvm.org/D58472