[PATCH] D58313: [hwasan,asan] Intercept vfork.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked 2 inline comments as done.
eugenis added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_rtl.cc:602
+  AsanThread *t = GetCurrentThread();
+  CHECK(t);
+  return t->extra_spill_area();
----------------
vitalybuka wrote:
> redundant CHECK here and below
why? GetCurrentThread may return 0 is called very early or very late.
There is not much we can do in that case, but the check at least replaces UB with a nice crash.


================
Comment at: compiler-rt/test/asan/TestCases/Linux/vfork.cc:4
+
+// REQUIRES: aarch64-android-target-arch
+
----------------
pcc wrote:
> Doesn't this need to be spelled `REQUIRES: aarch64-target-arch, android`? (Also, does it really require Android?)
I've dumped available features, and that's the only relevant one I found.
Perhaps this could be fixed, but in a separate commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58313/new/

https://reviews.llvm.org/D58313