[PATCH] D57927: [llvm-ar] Implement the P modifier.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 17:14:07 PST 2019


On Wed, Feb 20, 2019 at 5:07 PM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added a comment.
>
> > Hmm, that's right. That's probably a good reason why we can't make P the
> default behavior.
>
> Doesn't that make the output dependent on the build directory path? In
> Chromium, we're very careful to try and make the build independent of the
> build directory name for deterministic builds. I think changing the default
> here is bad for this reason. If you have your mind set on this however, is
> there an opt out flag? (We don't use llvm-ar in chromium at the moment so
> this doesn't affect us, but it's maybe a concern you didn't think about, so
> I figured I'd mention it.)
>

I'm not sure if I follow. You don't want to make P default? If so, that's I
think the conclusion of this thread. P is not enabled by default (unless
you specify P).


> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D57927/new/
>
> https://reviews.llvm.org/D57927
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190220/ad09085c/attachment.html>


More information about the llvm-commits mailing list