[PATCH] D58421: Add partial implementation of std::to_address() as llvm::to_address()

Glen Fernandes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 17:03:22 PST 2019


glenjofe added inline comments.


================
Comment at: llvm/trunk/include/llvm/ADT/STLExtras.h:1582-1583
+/// The late bound return should be removed once we move to C++14 to better
+/// align with the C++20 declaration. Also, this implementation can be removed
+/// once we move to C++20 where it's defined as std::to_addres()
+///
----------------
Is this necessary because you do not have access to `__to_raw_pointer()` in libc++? That is available in pre-C++20. The actual implementation of `std::to_address()` in libc++ is what I implemented in `__to_raw_pointer()` in D35470.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58421/new/

https://reviews.llvm.org/D58421





More information about the llvm-commits mailing list