[PATCH] D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Chunks.h:218
+
+  virtual bool isHotPatchable() const override {
+    return File->isHotPatchable();
----------------
LLVM coding standard recommends you omit `virtual` if `override` is given.


================
Comment at: COFF/InputFiles.cpp:608
+
+void ObjFile::initializeFlags() {
+  ArrayRef<uint8_t> Data = getDebugSection(".debug$S");
----------------
It needs a function comment.


================
Comment at: COFF/InputFiles.h:148
+  // True if this file was compiled with /hotpatch
+  bool isHotPatchable();
+
----------------
Looks like you can directly use `HotPatchable` instead of this function, and you can remove this function.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49366/new/

https://reviews.llvm.org/D49366