[PATCH] D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis

Wed Feb 20 14:24:59 PST 2019

scott.linder added inline comments.

================
Comment at: test/MC/AMDGPU/branch-comment.s:15
+loop_end:
+  s_nop 0
----------------
arsenm wrote:
> arsenm wrote:
> > Can you include some cases where it can't figure out an associated symbol?
> Also could use some stressing the maximum branch distances. There's some macro trick one of the other tests uses to produce a lot of nops for this
I added tests for the boundaries when assembling an immediate, and tests for failure due to the immediate being out of range, but the test you mention (`test/MC/AMDGPU/branch-comment-fail.s`) already handles the symbolic case, so I don't think there is anything to add.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58400/new/

https://reviews.llvm.org/D58400