[PATCH] D58466: [AArch64][GlobalISel] Implement partial support for G_SHUFFLE_VECTOR

[Amara Emerson via Phabricator via llvm-commits]

aemerson marked 2 inline comments as done.
aemerson added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:1995-1996
+  // G_SHUFFLE_VECTOR is weird in that the source operands can be scalars, if
+  // it's originated from a <1 x T> type. Those should have been custom
+  // legalized into something else before we get here.
+  if (!Src1Ty.isVector() || !Src2Ty.isVector())
----------------
paquette wrote:
> Should we die here then? Or add some debug output to make it easier to grep logs for if it happens?
I'd rather not us die here for now, until we're really sure that all "scalar" shuffles are handled before selection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58466/new/

https://reviews.llvm.org/D58466