[PATCH] D58400: [AMDGPU] Implement AMDGPUMCInstrAnalysis

[Scott Linder via Phabricator via llvm-commits]

scott.linder updated this revision to Diff 187669.
scott.linder marked 4 inline comments as done.
scott.linder added a comment.

Address feedback. Sign-extend all s_branch immediates and change the assembler syntax to represent these as true negative numbers.

One remaining question I have is about "overflow" in the calculation of the target; for example the test for the smallest simm16 on a branch at a low PC results in the offset `<keep_symbol+0xfffffffffffe0018>`but I don't know if the hardware is defined to behave this way. I will try to experiment, but I'm unsure how to know definitively.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58400/new/

https://reviews.llvm.org/D58400

Files:
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
  lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp
  lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.h
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCTargetDesc.cpp
  lib/Target/AMDGPU/SIInstrInfo.td
  test/MC/AMDGPU/branch-comment-fail.s
  test/MC/AMDGPU/branch-comment.s
  test/MC/AMDGPU/gfx7_asm_all.s
  test/MC/AMDGPU/gfx8_asm_all.s
  test/MC/AMDGPU/gfx9_asm_all.s
  test/MC/Disassembler/AMDGPU/gfx8_dasm_all.txt
  test/MC/Disassembler/AMDGPU/gfx9_dasm_all.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58400.187669.patch
Type: text/x-patch
Size: 20779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190220/02e6d08d/attachment.bin>