[PATCH] D58471: [CMake][runtimes] Set clang-header dependency for builtins

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 13:45:46 PST 2019


smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/runtimes/CMakeLists.txt:214
   function(builtin_default_target compiler_rt_path)
+    cmake_parse_arguments(ARG "" "" "DEPS" ${ARGN})
+
----------------
Any reason for spelling these as "DEPS" instead of the standard CMake spelling of "DEPENDS"?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58471/new/

https://reviews.llvm.org/D58471





More information about the llvm-commits mailing list