[PATCH] D58250: [AIX][CMake] Changes for building on AIX with XL and GCC

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Config/abi-breaking.h.cmake:37-41
+#if !(defined(_AIX) && defined(__GNU__))
+#define LLVM_HIDDEN_VISIBILITY __attribute__ ((visibility("hidden")))
+#else
+#define LLVM_HIDDEN_VISIBILITY
+#endif
----------------
chandlerc wrote:
> Is this correct though? I would expect non-hidden visibility checks to break things.
My understanding is yes: AIX does not export by default. Maybe a comment in the code is warranted?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58250/new/

https://reviews.llvm.org/D58250