[PATCH] D58282: [x86] scalarize extract element 0 of FP math

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 12:43:02 PST 2019


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:34233
+  case ISD::FMINNUM_IEEE: case ISD::FMAXNUM_IEEE:
+  case ISD::FMAXIMUM: case ISD::FMINIMUM: {
+    // extract (fp X, Y, ...), 0 --> fp (extract X, 0), (extract Y, 0), ...
----------------
(style) Is clang-format happy with this?


================
Comment at: llvm/test/CodeGen/X86/extractelement-fp.ll:138
   %v = call <4 x float> @llvm.sqrt.v4f32(<4 x float> %x)
   %r = extractelement <4 x float> %v, i32 0
   ret float %r
----------------
Should unary ops handle non-zero index extractions?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58282/new/

https://reviews.llvm.org/D58282





More information about the llvm-commits mailing list