[PATCH] D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 11:46:14 PST 2019


aganea added inline comments.


================
Comment at: test/COFF/functionpadmin.test:7
+RUN: lld-link %S/Inputs/precomp-a.obj /out:%t.exe /nodefaultlib /force /functionpadmin
+RUN: llvm-objdump -s %t.exe | FileCheck %s --check-prefix PADDED
+
----------------
rnk wrote:
> Why objdump -s instead of objdump -d to look at the disassembly? Maybe the idea is that part of the test is to show that .rdata sections and .pdata sections are not padded with 0xCC? I guess that's good.
Yes that was part of Peter's suggestion for testing: ensure only code sections were padded.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49366/new/

https://reviews.llvm.org/D49366





More information about the llvm-commits mailing list