[PATCH] D58411: Update `ld.lld --version` string for monorepo.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 20 10:47:45 PST 2019
ruiu added inline comments.
================
Comment at: lld/Common/CMakeLists.txt:5
+find_first_existing_vc_file("${LLVM_MAIN_SRC_DIR}" llvm_vc)
+find_first_existing_vc_file("${LLD_SOURCE_DIR}" lld_vc)
----------------
phosek wrote:
> I don't think this is used?
Removed.
================
Comment at: lld/Common/Version.cpp:19
-// Returns an SVN repository name, e.g., " (trunk 284614)"
-// or an empty string if no repository info is available.
-static std::string getRepository() {
- std::string Repo = getRepositoryPath();
- std::string Rev = LLD_REVISION_STRING;
-
- if (Repo.empty() && Rev.empty())
- return "";
- if (!Repo.empty() && !Rev.empty())
- return " (" + Repo + " " + Rev + ")";
- return " (" + Repo + Rev + ")";
-}
+using namespace llvm;
----------------
mgorny wrote:
> Are you actually using it?
Removed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58411/new/
https://reviews.llvm.org/D58411
More information about the llvm-commits
mailing list