[PATCH] D49366: [LLD][COFF] Add support for /FUNCTIONPADMIN command-line option

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: COFF/InputFiles.cpp:621
+    if (SS.kind() != DebugSubsectionKind::Symbols)
+      return;
+
----------------
There's a typo here - it shall read be `continue;` instead of `return;`.


================
Comment at: COFF/InputFiles.h:163
 
+  llvm::Optional<bool> HotPatchable;
+
----------------
ruiu wrote:
> Why Optional?
It's a reliquate. Fixed.
I'll also change it for `PCHSignature` above in a subsequent NFC patch.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49366/new/

https://reviews.llvm.org/D49366