[PATCH] D58327: [Dominators] Simplify and optimize path compression used in link-eval forest.

Wed Feb 20 10:33:57 PST 2019

NutshellySima added a comment.

In D58327#1403532 <https://reviews.llvm.org/D58327#1403532>, @MaskRay wrote:

> ...
>  And how can I benchmark dynamic dominator tree? `CalculateFromScratch` is easy to benchmark as I can just repeatedly run the function analysis `domtree` and discard the result but I don't know how for the dynamic case...

You can reference the code in D50300 <https://reviews.llvm.org/D50300> to time incremental updater primitives. I recommend you to find some projects which have large functions, probably machine generated code, for example, the one mentioned in Bug 37929 <https://bugs.llvm.org/show_bug.cgi?id=37929>. Bitcodes which have large functions can make improvement more observable. I remember incremental DT updating happens intensively in some passes like JumpThreading, so you can run `O3` and save a `.bc` before jumpthreading. It can save you some time when benchmarking.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58327/new/

https://reviews.llvm.org/D58327