[PATCH] D58359: [Analysis] fold load of untouched alloca to undef

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 08:51:31 PST 2019


reames added a comment.

JFYI, I disagree w/the sentiment expressed that we shouldn't do obvious memory optimizations in InstCombine.  InstCombine does local peephole optimizations *including memory optimizations*.  Even if I accept the stated goal that it *shouldn't*, today it *does* and there's no reason to reject this patch.

Now, we should *also* handle this transform in GVN/DSE/etc..., but that's a different point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58359/new/

https://reviews.llvm.org/D58359





More information about the llvm-commits mailing list