[PATCH] D58451: [DebugInfo] Fix the type of the formated variable

[Miloš Stojanović via Phabricator via llvm-commits]

mstojanovic created this revision.
mstojanovic added reviewers: rafauler, JDevlieghere, zoran.jovanovic, petarj.
Herald added subscribers: atanasyan, arichardson, sdardis.

Change the format type of Personality and LSDAAddress to PRIx64 since they are of type uint64_t.
The problem was detected on mips builds, where it was printing junk values and causing test failure.


https://reviews.llvm.org/D58451

Files:
  lib/DebugInfo/DWARF/DWARFDebugFrame.cpp


Index: lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
===================================================================
--- lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
+++ lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
@@ -300,7 +300,7 @@
   OS << format("  Data alignment factor: %d\n", (int32_t)DataAlignmentFactor);
   OS << format("  Return address column: %d\n", (int32_t)ReturnAddressRegister);
   if (Personality)
-    OS << format("  Personality Address: %08x\n", *Personality);
+    OS << format("  Personality Address: %08" PRIx64 "\n", *Personality);
   if (!AugmentationData.empty()) {
     OS << "  Augmentation data:    ";
     for (uint8_t Byte : AugmentationData)
@@ -319,7 +319,7 @@
                (uint32_t)InitialLocation,
                (uint32_t)InitialLocation + (uint32_t)AddressRange);
   if (LSDAAddress)
-    OS << format("  LSDA Address: %08x\n", *LSDAAddress);
+    OS << format("  LSDA Address: %08" PRIx64 "\n", *LSDAAddress);
   CFIs.dump(OS, MRI, IsEH);
   OS << "\n";
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58451.187585.patch
Type: text/x-patch
Size: 990 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190220/4fc48415/attachment.bin>