[PATCH] D58406: Fix IR/Analysis layering issue in OptBisect
Fedor Sergeev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 20 07:48:31 PST 2019
fedor.sergeev added a comment.
The need for generic way of getting textual description for IRUnit is obvious both in legacy and new pass manager.
However in this particular approach I dont like how "const void*" is used to erase specific type of IRUnit.
In new pass manager there was a similar task of erasing the type of IRUnit for pass-instrumentation purposes.
And there we decided to wrap the pointer into llvm::Any.
I'm not sure llvm::Any is the best approach here, but it sounds better than absolute anarchy of const void*.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58406/new/
https://reviews.llvm.org/D58406
More information about the llvm-commits
mailing list