[PATCH] D58445: [yaml2obj]Allow symbol Index field to take values lower than SHN_LORESERVE

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 07:29:59 PST 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

> @jhenderson wrote:
>  In this case, I think if you've explicitly used Index, you probably know what you are doing by specifying an explicit section index outside the reserved range, instead of using one of the SHN_* values or using the Section field.

Yes, for this case you are right I think.

LGTM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58445/new/

https://reviews.llvm.org/D58445





More information about the llvm-commits mailing list