[PATCH] D58439: [obj2yaml]Locate tests ending in .yaml

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 20 05:40:21 PST 2019


jhenderson updated this revision to Diff 187556.
jhenderson added a comment.

Not quite sure what was/is going on. I ran my diff script incorrectly before, hence the "C:" bit. I don't know why this file is showing up as modified rather than added. I've uploaded a diff with the path cleaned up.

I see the issue when I explicitly run lit on the obj2yaml test folder (i.e. running the llvm-lit.py script on Windows). I haven't tried check-llvm etc, so it's possible that uses a different mechanism to find the tests, but are you sure it's running the tests under test/tools/obj2yaml under in '.yaml'? Either way the basic test/lit.cfg.py clearly listst the default config.suffixes as `config.suffixes = ['.ll', '.c', '.cxx', '.test', '.txt', '.s', '.mir']`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58439/new/

https://reviews.llvm.org/D58439

Files:
  test/tools/obj2yaml/lit.local.cfg


Index: test/tools/obj2yaml/lit.local.cfg
===================================================================
--- test/tools/obj2yaml/lit.local.cfg
+++ test/tools/obj2yaml/lit.local.cfg
@@ -0,0 +1 @@
+config.suffixes = ['.yaml']


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58439.187556.patch
Type: text/x-patch
Size: 228 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190220/1992214d/attachment.bin>


More information about the llvm-commits mailing list