[PATCH] D58234: [llvm-objcopy] Add --add-symbol

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:320
+                       [&Type] { setTypeOnce(Type, ELF::STT_GNU_IFUNC); })
+            .CaseLower("debug", [] {})
+            .CasesLower("constructor", "warning", "indirect", "synthetic",
----------------
evgeny777 wrote:
> jhenderson wrote:
> > Could this be folded in with the other ones below?
> CasesLower supports up to 5 string parameters. Are you suggesting to add another variant which takes 6 ones?
Ah, I didn't realise that. This is fine then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58234/new/

https://reviews.llvm.org/D58234