[PATCH] D58416: [llvm-cxxfilt] Split and demangle stdin input on certain non-alphanumerics.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-cxxfilt/delimiters.test:30
+RUN:      "_Z3Foo}"   \
+RUN:      "_Z3Foo~,," \
+RUN:      '_Z3Foo$ ._Z3Foo' | llvm-cxxfilt | FileCheck %s
----------------
It may be worth adding one more demanglable string after this one here, to show that multiple delimiters can be handled and it doesn't completely stop demangling.


================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:89
+  // The beginning of the string.
+  StringRef::iterator First = Source.begin();
+
----------------
Nit: this and similar lines below are valid uses of `auto`.


================
Comment at: llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp:114
+  // '$' and '.' in mangled names are reserved for private implementations.
+  return isalnum(C) || C == '.' || C == '$' || C == '_';
+}
----------------
I take it c++filt does not split on those characters?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58416/new/

https://reviews.llvm.org/D58416