[PATCH] D58351: ARM: Add ImmArg to intrinsics

[Diana Picus via Phabricator via llvm-commits]

rovka added a comment.

Can you explain why this is relevant only for GCC builtins that don't require mangling? Otherwise LGTM.



================
Comment at: include/llvm/IR/IntrinsicsARM.td:317
 def int_arm_mrrc2 : Intrinsic<[llvm_i32_ty, llvm_i32_ty], [llvm_i32_ty,
                                llvm_i32_ty, llvm_i32_ty], []>;
 
----------------
I think these should also have immediate arguments, at least according to https://reviews.llvm.org/source/clang/browse/cfe/trunk/test/Sema/builtins-arm.c

Is there any reason why we should skip them? (I can see that they're just Intrinsic as opposed to GCCBuiltin, and the commit message says they wouldn't be included, but I don't really understand why you chose only GCCBuiltins).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58351/new/

https://reviews.llvm.org/D58351