[PATCH] D57680: [llvm-objdump] Implement `-Mreg-names-raw`/`-std` options.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked 6 inline comments as done.
ikudrin added inline comments.


================
Comment at: lib/Target/ARM/InstPrinter/ARMInstPrinter.cpp:83
+  } else
+    return false;
+}
----------------
jhenderson wrote:
> grimar wrote:
> > You can avoid using `else` after `return`:
> > 
> > ```
> > if (Opt == "reg-names-std") {
> >   DefaultAltIdx = ARM::NoRegAltName;
> >   return true;
> > } 
> > if (Opt == "reg-names-raw") {
> >   DefaultAltIdx = ARM::RegNamesRaw;
> >   return true;
> > } 
> > return false;
> > ```
> There's still an `else if`  a few lines up here, which can just become a regular if, as @grimar proposed.
Oops! Didn't notice that. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57680/new/

https://reviews.llvm.org/D57680