[PATCH] D58423: ELF: Remove field for .gdb_index in InStruct. NFC.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 18:25:29 PST 2019


MaskRay created this revision.
MaskRay added reviewers: ruiu, pcc.
Herald added subscribers: llvm-commits, arphaman, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This field is unreferenced outside of createSyntheticSections.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D58423

Files:
  ELF/SyntheticSections.h
  ELF/Writer.cpp


Index: ELF/Writer.cpp
===================================================================
--- ELF/Writer.cpp
+++ ELF/Writer.cpp
@@ -384,10 +384,8 @@
   In.IgotPlt = make<IgotPltSection>();
   Add(In.IgotPlt);
 
-  if (Config->GdbIndex) {
-    In.GdbIndex = GdbIndexSection::create<ELFT>();
-    Add(In.GdbIndex);
-  }
+  if (Config->GdbIndex)
+    Add(GdbIndexSection::create<ELFT>());
 
   // We always need to add rel[a].plt to output if it has entries.
   // Even for static linking it can contain R_[*]_IRELATIVE relocations.
Index: ELF/SyntheticSections.h
===================================================================
--- ELF/SyntheticSections.h
+++ ELF/SyntheticSections.h
@@ -1008,7 +1008,6 @@
   GnuHashTableSection *GnuHashTab;
   HashTableSection *HashTab;
   InputSection *Interp;
-  GdbIndexSection *GdbIndex;
   GotSection *Got;
   GotPltSection *GotPlt;
   IgotPltSection *IgotPlt;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D58423.187486.patch
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190220/49b6713b/attachment.bin>


More information about the llvm-commits mailing list