[PATCH] D58337: [WebAssembly] Fix load/store name detection for atomic instructions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 19 17:17:33 PST 2019


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrAtomics.td:340
               !strconcat(Name, "\t$dst, ${off}(${addr})${p2align}, $val"),
-              !strconcat(Name, "\t${off}, ${p2align}"), Opcode>;
+              !strconcat(Name, "\t${off}${p2align}"), Opcode>;
 }
----------------
aardappel wrote:
> Is this syntax in line with all other uses of p2align in .td?
Yes: [[ https://github.com/llvm/llvm-project/blob/979587d91dbea0e3757db4ceb0045a51e85c6d81/llvm/lib/Target/WebAssembly/WebAssemblyInstrMemory.td#L60 | example ]]


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58337/new/

https://reviews.llvm.org/D58337





More information about the llvm-commits mailing list