[PATCH] D58315: [WebAssembly] Add .shared_memory directive

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.cpp:163
+  Sym->setMemFlags(wasm::WASM_LIMITS_FLAG_HAS_MAX |
+                   wasm::WASM_LIMITS_FLAG_IS_SHARED);
+}
----------------
It still seems wrong to attach this information to a symbol, is there not some module level state we can attach it too?

I don't think __linear_memory should be and MCSymbol at all.  We don't have a symbol type for a memory.   It looks like it is referenced in WasmObjectWriter.cpp but I can't see why it would be.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58315/new/

https://reviews.llvm.org/D58315